Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak fusion regression #2683

Merged
merged 41 commits into from
Jan 16, 2025
Merged

Tweak fusion regression #2683

merged 41 commits into from
Jan 16, 2025

Conversation

lintool
Copy link
Member

@lintool lintool commented Jan 16, 2025

Patch on top of #2627

@lintool lintool requested a review from wu-ming233 January 16, 2025 20:52
Copy link
Member

@wu-ming233 wu-ming233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.03%. Comparing base (97c71bd) to head (735b44d).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2683   +/-   ##
=========================================
  Coverage     66.03%   66.03%           
  Complexity     1487     1487           
=========================================
  Files           225      225           
  Lines         13033    13033           
  Branches       1553     1553           
=========================================
  Hits           8606     8606           
  Misses         3895     3895           
  Partials        532      532           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lintool
Copy link
Member Author

lintool commented Jan 16, 2025

Confirmed that this sequence works:

python src/main/python/run_regression.py --index --verify --search --regression beir-v1.0.0-robust04.flat
python src/main/python/run_regression.py --index --verify --search --regression beir-v1.0.0-robust04.bge-base-en-v1.5.parquet.flat.cached

python src/main/python/run_fusion_regression.py --regression beir-v1.0.0-robust04

@lintool lintool merged commit 0e7b63c into master Jan 16, 2025
3 checks passed
@lintool lintool deleted the Stefan824-add-fusion-regression branch January 16, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants