Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch NPE introduced in recent commit. #816

Merged
merged 2 commits into from
Sep 27, 2019
Merged

Catch NPE introduced in recent commit. #816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8ec49c
Catch NPE introduced in recent commit.
Sep 27, 2019
d8be40b
Update known issues.
Sep 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/known-issues/known-issues-v0.6.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# Anserini Known Issues (v0.6.0)

+ Solr indexing for Washington Post broke due to [417ac12](https://github.com/castorini/anserini/commit/c5ee9af442c500ec43fc28808903cfca2417ac12) and has been fixed in [#807](https://github.com/castorini/anserini/pull/807) and [#809](https://github.com/castorini/anserini/pull/809).
+ Solr indexing for Washington Post broke due to [417ac12](https://github.com/castorini/anserini/commit/c5ee9af442c500ec43fc28808903cfca2417ac12) and has been fixed in [#807](https://github.com/castorini/anserini/pull/807) and [#809](https://github.com/castorini/anserini/pull/809).
+ SearchSolr is broken due to [72b8052](https://github.com/castorini/anserini/commit/ca253a4794b5f5bea38749bd40e5f9f4272b8052) and has been fixed in [#816](https://github.com/castorini/anserini/pull/816).
2 changes: 1 addition & 1 deletion src/main/java/io/anserini/rerank/lib/ScoreTiesAdjusterReranker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public class ScoreTiesAdjusterReranker implements Reranker {
@Override
public ScoredDocuments rerank(ScoredDocuments docs, RerankerContext context) {

if (context.getSearchArgs().arbitraryScoreTieBreak) {
if (context != null && context.getSearchArgs().arbitraryScoreTieBreak) {
return docs;
}

Expand Down