Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilingual regression fixes #902

Merged
merged 7 commits into from
Nov 27, 2019
Merged

Multilingual regression fixes #902

merged 7 commits into from
Nov 27, 2019

Conversation

lintool
Copy link
Member

@lintool lintool commented Nov 27, 2019

@Impavidity this is all on tuna.

This one works fine:

nohup python src/main/python/run_regression.py --collection clef06-fr --index >& log.clef06-fr &

These work fine, but I caught a few typos:

nohup python src/main/python/run_regression.py --collection fire12-bn --index >& log.fire12-bn &
nohup python src/main/python/run_regression.py --collection fire12-hi --index >& log.fire12-hi &
nohup python src/main/python/run_regression.py --collection fire12-en --index >& log.fire12-en &

This appears to be broken:

nohup python src/main/python/run_regression.py --collection trec02-ar --index >& log.trec02-ar &

Also, the generated regression docs are different.

Can you please check?

@lintool lintool requested a review from Impavidity November 27, 2019 10:32
@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #902 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #902      +/-   ##
============================================
+ Coverage     36.01%   36.02%   +0.01%     
- Complexity      474      475       +1     
============================================
  Files           119      119              
  Lines          7139     7139              
  Branches       1082     1082              
============================================
+ Hits           2571     2572       +1     
  Misses         4289     4289              
+ Partials        279      278       -1
Impacted Files Coverage Δ Complexity Δ
...anserini/ltr/feature/base/PMIFeatureExtractor.java 86.53% <0%> (+1.92%) 13% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd47b91...ccf339e. Read the comment docs.

@lintool
Copy link
Member Author

lintool commented Nov 27, 2019

@Impavidity verified that AR fixed.

Copy link
Member

@Impavidity Impavidity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lintool lintool merged commit b9264da into master Nov 27, 2019
@lintool lintool deleted the multilingual-tests branch November 27, 2019 19:48
crystina-z pushed a commit to crystina-z/anserini that referenced this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants