Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add monot5 tpu train doc #108

Merged
merged 3 commits into from
Nov 11, 2020
Merged

add monot5 tpu train doc #108

merged 3 commits into from
Nov 11, 2020

Conversation

MXueguang
Copy link
Member

No description provided.

rodrigonogueira4
rodrigonogueira4 reviewed Nov 4, 2020
View reviewed changes
Copy link
Member

@rodrigonogueira4 rodrigonogueira4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just a few minor comments

MXueguang and others added 2 commits November 5, 2020 05:52
@MXueguang
Copy link
Member Author

When this PR finish, #107 will be my next PR, fyi

@ronakice ronakice self-requested a review November 11, 2020 16:20
ronakice
ronakice approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@ronakice ronakice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging

@ronakice ronakice merged commit da0fb61 into castorini:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigonogueira4 rodrigonogueira4 rodrigonogueira4 left review comments

@ronakice ronakice ronakice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MXueguang @rodrigonogueira4 @ronakice