Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Clip and OpenAi query encoders #2014

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Refactor Clip and OpenAi query encoders #2014

merged 5 commits into from
Oct 15, 2024

Conversation

lintool
Copy link
Member

@lintool lintool commented Oct 13, 2024

Other minor tweaks/fixes along the way

@lintool lintool marked this pull request as draft October 13, 2024 13:54
@lintool lintool marked this pull request as ready for review October 15, 2024 12:10
@lintool
Copy link
Member Author

lintool commented Oct 15, 2024

@MXueguang @jasper-xian @justram I think this is ready, I've run the following:

nohup python -m pyserini.2cr.atomic --all --directory runs/ --display-commands >& logs/log.atomic &

nohup python -m pyserini.2cr.msmarco --collection v1-passage --condition openai-ada2 --directory runs/ --display-commands >& logs/log.openai-ada2 &
nohup python -m pyserini.2cr.msmarco --collection v1-passage --condition openai-ada2-hyde --directory runs/ --display-commands >& logs/log.openai-ada2-hyde &
nohup python -m pyserini.2cr.msmarco --collection v1-passage --condition openai-text-embedding-3-large --directory runs/ --display-commands >& logs/log.openai-text-embedding-3-large &

The OpenAI runs were successful.
The AToMiC run gives the same result as #2015

@lintool lintool merged commit 75aea32 into master Oct 15, 2024
@lintool lintool deleted the refactoring branch October 15, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants