Update to Webpack 5 #197
Merged
Update to Webpack 5 #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- offline-plugin doesn't support Webpack 5 so we have to switch to workbox-webpack-plugin. - webpack-merge removed support for merge.smart so we had to update usage. - webpack has caching built in now so hard-source-webpack-plugin is no longer needed. - webpack removed automatic polyfills for Node APIs so we have to install the "buffer" package manually. - css-loader had the minimize option removed. - copy-plugin had some options change. - webpack removed the ability to specify complex loader strings in the webpack config so the imports/exports for tweetnacl had to be reworked. - webpack no longer needs HashedModuleIdsPlugin.
- worker-loader started exporting the result as a default import instead of a bare commonjs import
- vue-style-loader is not compatible with css-loader 5.x - Also vue-style-loader is really only used for Server Side Rendering support (which we don't use)
- Will have changes to fix the Chrome loading issue. (webpack-contrib/worker-loader#292)
- It is only going to be used internally so there is no reason to publish it
# Conflicts: # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged, this PR will update Webpack to version 5.
Notes
URL.revokeObjectURL()is called immediately after creating the worker. (See worker-loader#292) To fix this a fork of worker-loader was made which runsURL.revokeObjectURL()1 second after the worker was created.