-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Port] Add in-game progression diary #1965
[Port] Add in-game progression diary #1965
Conversation
Will fix clang-tidy later |
Ready for review, I updated the description with the new changes |
@@ -363,6 +364,14 @@ int avatar::time_to_read( const item &book, const player &reader, const player * | |||
return retval; | |||
} | |||
|
|||
diary *avatar::get_avatar_diary() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be better to initialize the diary on construction and then return a proper reference to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave this one unresolved since we agreed on Discord to leave it like that for now, but it would be great if someone with better cpp skills took the time to take care of it.
I noticed that "since last entry" can "understand" when an entry was deleted. That's good. |
Summary
Purpose of change
Fixes #1917
An in-game way to take notes was something missing in the game, so when I saw that someone already made it in DDA (+extra features), I just had to port it
Describe the solution
Port the diary
CleverRaven/Cataclysm-DDA#52372 (Original PR)
CleverRaven/Cataclysm-DDA#53576 (Fix typos)
CleverRaven/Cataclysm-DDA#55045 (INFO menu option)
CleverRaven/Cataclysm-DDA#53582 (Better translation support for head text)
CleverRaven/Cataclysm-DDA#54720 (Clean code, fix typos)
CleverRaven/Cataclysm-DDA#56253 (Add more robust code that fixes several bugs)
CleverRaven/Cataclysm-DDA#57321 (Change the pop op after an edit to Yes by default)
A few personal modifications
Comparison between the current BN and DDA versions
At the limit
![image](https://user-images.githubusercontent.com/71428793/195412650-5f414541-90ae-4bcb-8d37-ed4a30d28a48.png)
Above the limit
![image](https://user-images.githubusercontent.com/71428793/195412380-09c3a593-4868-4c6c-acb6-ea1be57066fa.png)
Testing
I did the same tests as in the original PR:
(Since last changes)