Fix consumption of mixed ammo in magazines #2004
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix consumption of mixed ammo in magazines"
Purpose of change
When reloading a magazine with a mix of favorite and non-favorite ammo the 2 types stay as separate stacks inside the magazine.
But the gun code isn't "quite there" when it comes to handling mixed ammo, so the part where they're consumed mistakenly uses
back()
instead offront()
to refer to the stack to remove, which ends up with wrong stack of ammo being erased.Example repro steps:
Glock 31
Describe the solution
Fix
back()
->front()
Testing
Repeated repro steps, bug is fixed