Bump vcpkg version to fix msvc builds #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarf005
added a commit
to scarf005/Cataclysm-BN
that referenced
this pull request
Oct 20, 2022
locally merge cataclysmbnteam#2091 in order to check if build succeeds Co-authored-by: Olanti <olanti-p@yandex.ru>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Build "Bumped vcpkg version to fix msvc builds"
Purpose of change
Closes #2082
Describe the solution
Bump vcpkg version to latest-ish. It includes the change to zlib port file that makes it download the source code for version 1.2.12 from github mirror where it's still available.
It's a trivial change, yet should last us for another half a year or so if the trend continues.
Testing
Compiles locally, no game-breaking issues were noticed.
Opened the PR to test GitHub workflow, should work with no further changes.
Additional context
People with existing VS+vcpkg build setups will need to manually update their vcpkg.
Assuming the setup matches one described in the doc, this can be done in 2 steps:
C:\dev\vcpkg) in cmd and run: