Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several prying/picking tools bugs #2135

Merged

Conversation

leoCottret
Copy link
Collaborator

@leoCottret leoCottret commented Oct 28, 2022

Summary

SUMMARY: Bugfixes "Fix several prying/picking tools bugs"

Purpose of change

Fixes #2130

  • manholes and coffins were missing a json field
  • when checking for the best items with lockpick/prying qualities, wearable items weren't taken into account

Fixes #1923

  • basically what is in the issue, the parameter was passed to the function but never used

Describe the solution

2130
  • add the missing json field so that they can be pried open with examine
  • remove the check on wearable item
    • you can directly lockpick a lockpickable thing with a worn hairpin
    • you can also pry a pryable thing with crowbar in a toolbelt
1923
  • make the function ask for a direction only if the parameter passed isn't valid

Testing

  • worn item: hairpin (action and examine key)
    • sealed coffin: no
    • crate: no
    • man hole: no
    • locked wood door: yes
    • gun safe: yes
  • worn item: toolbelt with crowbar (examine only)
    • sealed coffin: yes
    • crate: yes
    • man hole: yes
    • locked wood door: yes
    • gun safe: no
  • crowbar (action and examine key)
    • sealed coffin: yes
    • crate: yes
    • man hole: yes
    • locked wood door: yes
    • gun safe: no

@scarf005 scarf005 added src changes related to source code. JSON related to game datas in JSON format. labels Oct 30, 2022
@Coolthulhu Coolthulhu self-assigned this Oct 30, 2022
src/iexamine.cpp Outdated Show resolved Hide resolved
@Coolthulhu Coolthulhu merged commit 8d367e5 into cataclysmbnteam:upload Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. src changes related to source code.
Projects
None yet
3 participants