Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overmap_debug_mongroup #2144

Merged

Conversation

KheirFerrum
Copy link
Collaborator

Summary

SUMMARY: Bugfixes "Remove overmap_debug_mongroup"

Purpose of change

While porting #2089 I accidentally included this into savegame_json.cpp under write but not read. It's a variable used in DDA but not in BN that I accidentally included while solving merge conflicts.

Describe the solution

Removes overmap_debug_mongroup from savegame_json.cpp entirely.

Describe alternatives you've considered

  • Add in whatever it's supposed to reference.
    I actually have no clue what it actually does and looking for it might take a while. I'd rather do that some other time, especially if it turns out that it's not something we even want.

Testing

Save load, then turn on "Report Unused JSON Fields", verified that the error no longer triggered.

Additional context

I really need to set "Report Unused JSON Fields" as true for all my test builds.

@github-actions github-actions bot added the src changes related to source code. label Oct 31, 2022
@Coolthulhu Coolthulhu self-assigned this Nov 15, 2022
@Coolthulhu Coolthulhu merged commit 6a5701e into cataclysmbnteam:upload Nov 21, 2022
@KheirFerrum KheirFerrum deleted the Distraction-Manager-Cleanup branch November 21, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants