Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Remove overmap_debug_mongroup"
Purpose of change
While porting #2089 I accidentally included this into
savegame_json.cpp
under write but not read. It's a variable used in DDA but not in BN that I accidentally included while solving merge conflicts.Describe the solution
Removes
overmap_debug_mongroup
fromsavegame_json.cpp
entirely.Describe alternatives you've considered
I actually have no clue what it actually does and looking for it might take a while. I'd rather do that some other time, especially if it turns out that it's not something we even want.
Testing
Save load, then turn on "Report Unused JSON Fields", verified that the error no longer triggered.
Additional context
I really need to set "Report Unused JSON Fields" as true for all my test builds.