Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Active Exception to deploy_furn #2300

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

KheirFerrum
Copy link
Collaborator

@KheirFerrum KheirFerrum commented Jan 21, 2023

Summary

SUMMARY: Bugfix "Add Active Exception to deploy_furn"

Purpose of change

Arcana's candle of warding couldn't be set to active when actually active as it would proc the deploy_furn iuse action on every turn. A closer look revealed that it was because unlike most other iuse_actors it didn't check the bool that denoted that an item was being processed because of active item processing.

Describe the solution

Adds the check that most other iuse_actors use to prevent undesired triggers of iuse_actor. This merely prevents it from continuously proc'ing when active, it doesn't prevent the player from activating an item and using the deploy_furn action.

Describe alternatives you've considered

-Rework entire system so that we know what iuse actors are active/passive.
Not particularly useful unless we actually have a way to json define iuse_actors, future project?

Testing

Installed Arcana mod, edited candle of warding to turn active when transforming to active form. Loaded game, checked that both versions could be deployed by player activation, checked that on version of candle of warding didn't trigger deploy_furn every turn.

Additional context

Underlying system with if hooks for each iuse is kind of clunky, but for now it will suffice, reworking it should be on the agenda at some point.

Also @chaosvolt just so it's in your notifications.

@github-actions github-actions bot added the src changes related to source code. label Jan 21, 2023
@Coolthulhu Coolthulhu self-assigned this Jan 21, 2023
@Coolthulhu Coolthulhu merged commit a0eb281 into cataclysmbnteam:upload Jan 23, 2023
chaosvolt added a commit to chaosvolt/cdda-arcana-mod that referenced this pull request Jan 26, 2023
Thanks to cataclysmbnteam/Cataclysm-BN#2300 this can now be a thing for visual ID purposes, per request.
@KheirFerrum KheirFerrum deleted the Deploy-Furn-Fix branch January 31, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants