Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update looks like for small battery furniture #3337

Merged

Conversation

chaosvolt
Copy link
Member

Summary

SUMMARY: Interface "Set small battery furniture to not look like lockers"

Purpose of change

This accounts for the small battery furniture added recently not properly getting its looks_like from basic furniture batteries and defaulting to lockers instead. I opted to make them more distinct since they are less bulky and easier to make.

Describe the solution

Set the smaller battery furniture to have looks_like resembling plain storage battery items, in the vein of other basic placed tools.

Describe alternatives you've considered

Drawing up a custom sprite for smaller furniture batteries.

Testing

  1. Checked affected file for syntax and lint errors.
  2. Ported file change to test build and checked that small storage batteries, car batteries, and bike batteries looked like the item sprite when placed.

Additional context

Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshots pls

@chaosvolt
Copy link
Member Author

screenshots pls

image

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Oct 1, 2023
@scarf005 scarf005 added this pull request to the merge queue Oct 1, 2023
Merged via the queue into cataclysmbnteam:upload with commit 6921919 Oct 1, 2023
@chaosvolt chaosvolt deleted the better-battery-looks-like branch October 1, 2023 02:04
olanti-p pushed a commit to olanti-p/Cataclysm-BN that referenced this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants