Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unnecessary map settings overwrite on No Hope #4062

Merged

Conversation

RoyalFox2140
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 commented Jan 6, 2024

Purpose of change

Partially fixes #3993 by removing the offending file in No Hope. I found no notable differences in this file beyond missing content from vanilla.

Describe the solution

Removes regional_map_settings.json from No hope.

Describe alternatives you've considered

Adding missing entries.

Testing

Removing won't cause issues as it will use vanilla's map settings

Additional context

pain

@github-actions github-actions bot added JSON related to game datas in JSON format. mods PR changes related to mods. labels Jan 6, 2024
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

78mls4

@RoyalFox2140
Copy link
Collaborator Author

78mls4

I'm saving that.

@chaosvolt
Copy link
Member

 Warning: Failed to download action 'https://api.github.com/repos/ammaraskar/gcc-problem-matcher/tarball/d1fed1fac9e94d30e23b5a82dba4e2963e71d2e7'. Error: nodename nor servname provided, or not known (api.github.com:443)
Warning: Back off 12.922 seconds before retry.
Warning: Failed to download action 'https://api.github.com/repos/ammaraskar/gcc-problem-matcher/tarball/d1fed1fac9e94d30e23b5a82dba4e2963e71d2e7'. Error: nodename nor servname provided, or not known (api.github.com:443)
Warning: Back off 25.466 seconds before retry.

Weird tho

@scarf005
Copy link
Member

scarf005 commented Jan 6, 2024

image
https://github.com/cataclysmbnteam/Cataclysm-BN/actions/runs/7428665314/job/20220473942?pr=4062

looks like a temporary network failure. rerunning works.

@scarf005 scarf005 merged commit e24fb8a into cataclysmbnteam:main Jan 6, 2024
8 of 9 checks passed
@RoyalFox2140 RoyalFox2140 deleted the repair-no-hope-regiondata branch January 6, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Hope and Rural biome mod both have outdated mapgen data
3 participants