fix: map settings on rural biome updated with new additions #4063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
JSON
chaosvolt
approved these changes
Jan 6, 2024
scarf005
reviewed
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Partially fixes #3993
Rural biome mod was horribly out of date and missing bog iron, some plants and trees such as cacao and coca trees, and had burdock which doesn't appear in vanilla.
Describe the solution
Copied everything from the start of the vanilla file until map extra generation and replaced all of those fields in rural biome.
Describe alternatives you've considered
Possibly migrating away from a map settings overwrite, which may not be possible to blacklist urban locations that way.
Testing
it worked.
Additional context
pain