fix: Prevents reloading from deleting containers #4104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Fixes #4068.
Describe the solution
Moves magazine reloading to the new safer stack splitting system and moves the old charges==0 check to the one branch that still uses the old stuff.
Describe alternatives you've considered
Cleaning it up further, moving that last branch to the newer stuff and sorting out whatever's going on with speedloaders is probably a good idea at some point.
Testing
The reported bug (i.e. reloading liquids), reloading magazines, reloading singles and reloading with a speedloader.