-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(content): rice farming, rice bran, sake, sikhye #4120
Conversation
Added rice seeds, rice bran, sake, sikhye.
The Autofix app has found code style violation and automatically formatted this Pull Request. I locally edit my commits (e.g: git, github desktop)Please choose following options: I'd like to accept the automated commit
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. This PR is complete and I don't want to edit it anymoreIt's safe to ignore this message. I edit this PR through web UIYou can ignore this message and continue working. I have no idea what this message is talking aboutYou can ignore this message and continue working. If you find any problem, please ask for help and ping @scarf005. |
lol, sorry~ Co-authored-by: scarf <greenscarf005@gmail.com>
Co-authored-by: scarf <greenscarf005@gmail.com>
Co-authored-by: scarf <greenscarf005@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, haven't playtested yet tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked it over, discussed most of the changes already on the discord. Looks good to me.
Test fail:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chaosvolt pls merge after tests pass
Actually, I wanted to make wild rice forageable from bushes first. I forgot to actually make it spawn. |
pfft, aight XD EDIT: ihatecomestibletestsihatecomestibletestsihatecomestibletests |
Made it possible to forage wild rice from shrubs in the summer, since that's when they grow IRL.
Would you consider adding the |
Made rice seeds able to be made into bird feed, rice bran able to be made into bird feed, cattle feed, and flour.
Alright, I'll try the eaten_hot and eaten_cold flags together. Co-authored-by: NappingOcean <129575271+NappingOcean@users.noreply.github.com>
Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
Purpose of change
Rice is currently unfarmable, so I decided to make it farmable as well as add in related rice products such as rice bran, sake, and by Scarf's request, sikhe.
Describe the solution
Rice now is farmable in shallow water, and produces more of its own seeds (as well as straw) as a product. Rice seeds can be processed into dried rice with rice bran as a byproduct, and rice can now be used to make sake and sikhye, two new items. Rice bran is used to make vegetable oil.
I've also noticed that fruit wine only has a fun value of 2, so I've edited that to be 20.
Describe alternatives you've considered
Testing
The json checks out, it loads fine.
Additional context
Checklist