Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix some nondescript mission names, fix chemist mission #4131

Merged

Conversation

chaosvolt
Copy link
Member

Purpose of change

This fixes some minor issues with missions I spotted while poking around.

Describe the solution

  1. Set the chemist mission to actually ask for 100 liters of gasoline, not 500 ml. How did this even happen? 500 does not translate into 100 liters no matter what unit you assume it to be. As mentioned it's half a liter if interpreted as 1 ml each, but if the mission author assumed a unit was a liter that'd be 500 liters, and if assuming they were legacy volume units like water is then it'd be 125 liters.
  2. Fixed names of Jesse Issherwood's hunting missions to clarify that you're hunting wolves the first time, with the second mission retaining the "dunno what they are" bit.

Describe alternatives you've considered

I want to also write proper descriptions for more of the missions but figured I'd start with fixes first. Probably need to scrutinize the new missions Zlor ported over more in depth in case we missed any other oversights.

Testing

  1. Checked affected files for syntanx and lint errors.
  2. Did basic elementary-level math and confirmed that 100000 divided by 1000 equals 100.

Additional context

DDA still asks for half a liter of gasoline: https://github.com/CleverRaven/Cataclysm-DDA/blob/master/data/json/npcs/cabin_chemist/chemist_missions.json#L62

Relevant PR we ported: more NPC locations by @MNG-cataclysm: CleverRaven/Cataclysm-DDA#57483

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jan 19, 2024
@scarf005 scarf005 self-requested a review January 20, 2024 06:43
@scarf005 scarf005 self-assigned this Jan 20, 2024
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

while it works, the items aren't consumed? i guess it's another issue...

@scarf005 scarf005 merged commit 664c5a2 into cataclysmbnteam:main Jan 20, 2024
9 checks passed
@chaosvolt chaosvolt deleted the more-missiondef-descriptions branch January 20, 2024 08:36
@chaosvolt
Copy link
Member Author

Weird, when I tested the mission it ate the gas but left the container...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants