feat(balance): dial back nerf to skill impact on butchery a bit #4136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
So, a lot of feedback has come in suggesting that #3719 undervalued the impact of skills on butchery and dissection yields. A lot of this is ultimately because dissection isn't as granular as it could probably afford to be, so going so far as to break up, for example, the electronics skill being divided by 4 means it takes several levels for it to kick in and actually bump up your success result by any amount at all.
Describe the solution
activity_handlers::butcher_finish
so that the baseline definition ofskill_level
is back to using survival skill directly instead of cutting it in half (so result is a clean 0-10 instead of randomized 0-7).Success rates with the following tool qualities:
Fine cutting level 4 not implemented in vanilla, so omitted. Tested with average dexterity to avoid the weird RNG impact it adds. Goal here was setting it so you get reliably high success rate with a scalpel when both your skills hit level 5, while having the surgical CBM lets you reach perfection with only 3 in both skills.
Describe alternatives you've considered
Making the roll more granular would be nice but that'd require all of the processing involving
roll_butchery
and the functions that use them to deal infloat
instead ofint
.Testing
Additional context
Checklist