Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rebalancing and fixes for electric firestarters #4148

Merged
merged 4 commits into from
Feb 4, 2024

Conversation

chaosvolt
Copy link
Member

Purpose of change

This scales down the power draw of two of the useful-but-often-overlooked CBMs to be more in line with comparable non-bionic items.

Along the way I found an apparent issue with electric lighters that, it turns out, explains two bugs that were reported. Guess this turned into a bugfix PR by accident.
Fixes #3748
Fixes #3612

Describe the solution

  1. Scaled down power draw of finger laser from 30 kJ to 10 kJ, making it match the damnage and power cost of the V29 laser pistol.
  2. Scaled down power draw of finger ligher from 3 kJ to 1 kJ, matching the power draw of non-makeshift electric lighters.
  3. Converted electric lighter to copy from crude firestarter instead of regular lighter, to avoid charges fuckery that version may have, and set its charges_per_use to 1.
  4. Converted crude firestarter to be its own item and not inherit from lighters either because again, ammoless charges fuckery on a magazine-fed ammotype item.
  5. Added electric lighters and firestarters to charges removal blacklist.

Describe alternatives you've considered

Keeping power use of finger lighter at 3 kJ and giving elctric lighters a charges_per_use of 3 to match.

Testing

  1. Load-tested in compiled test build, confirmed "can't have charges" error I first encountered went away.
  2. Spawned in both firestarters and unloaded them. No errors, and electric lighter no longer works without a battery loaded.
  3. Saved and loaded afterward, still no errors.
  4. Installed a UPS conversion on both, no errors print on doing so, nor on a save/load afterward.

However, I found during testing that the firestarters still can't actually be activated once you install a UPS conversion kit on them. This I think needs to be reported as a separate bug?

Additional context

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jan 21, 2024
@chaosvolt
Copy link
Member Author

Tested UPS-modding a couple other items and it's still just firestarters that can't have work right with UPS, dafuq?
image

@scarf005 scarf005 merged commit d3ee92c into cataclysmbnteam:main Feb 4, 2024
9 checks passed
@chaosvolt chaosvolt deleted the electric-fingers branch February 4, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
2 participants