fix: rebalancing and fixes for electric firestarters #4148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
This scales down the power draw of two of the useful-but-often-overlooked CBMs to be more in line with comparable non-bionic items.
Along the way I found an apparent issue with electric lighters that, it turns out, explains two bugs that were reported. Guess this turned into a bugfix PR by accident.
Fixes #3748
Fixes #3612
Describe the solution
charges_per_use
to 1.Describe alternatives you've considered
Keeping power use of finger lighter at 3 kJ and giving elctric lighters a
charges_per_use
of 3 to match.Testing
However, I found during testing that the firestarters still can't actually be activated once you install a UPS conversion kit on them. This I think needs to be reported as a separate bug?
Additional context
Checklist