feat(balance): unarmed skill affects empty-handed damage again #4160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Every so often @Coolthulhu mentioned in the BN discord wanting to bring back some form of bonus damage to unarmed attacks scaling with skill, ideally in a form that would encourage the player to try fighting bare-handed at high unarmed skill as a viable alternative to unarmed weapons.
Describe the solution
In melee.cpp, set
Character::roll_bash_damage
so that theweap_dam
value gains a bonus equal to double that ofskill
, IF the user is fighting truly unarmed with no wielded weapon. This sets weapon damage to 20 at 10 unarmed skill, matching the performance of the katar and only outclassed (in-repo) by the bionic unarmed weapons.While this does get the same "you get double your unarmed skill in this value" effect of the old code, there are a couple main differences compared to the old bonus:
weap_dam
instead ofskill
means that it doesn't causebash_cap
andbash_mul
to scale above the expected skill values.bash_mul
that applies when below 5 skill with only 3 unarmed skill.Describe alternatives you've considered
Scaling it down to only 1x unarmed skill. Possibly in exchange for some combination of allowing it to be applied to unarmed weapons, and/or having truly unarmed attacks modify
armor_mult
orarpen
based on unarmed skill?This could either take the form of:
arpen
equal to or 0.5x unarmed skill.armor_mult
of something like1.0f - (0.025 * skill)
such that 10 unarmed skill provides a default armor multiplier of 0.75.Testing
Before:
After:
And here is same character build with a katar for comparison:
Additional context
Relevent PR: nerf unarmed damage, by @kevingranade: CleverRaven/Cataclysm-DDA#31858
Checklist