Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: uaf in safe references #4165

Merged
merged 2 commits into from
Jan 27, 2024
Merged

fix: uaf in safe references #4165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
120b521
Fixes a uaf in safe references
joveeater Jan 27, 2024
bafa373
style(autofix.ci): automated formatting
autofix-ci[bot] Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/safe_reference.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ class safe_reference
} else {
rec->mem_count--;
rec = rec->target.redirect;
rec->mem_count++;
}
}
}
Expand Down Expand Up @@ -368,13 +369,12 @@ class safe_reference
if( sec_rec->id == ID_NONE ) {
sec_rec->id = REDIRECTED_MASK;
sec_rec->target.redirect = pri_rec;
}

//They both have an id
if( pri_rec->id != ID_NONE && sec_rec->id != ID_NONE ) {
pri_rec->mem_count++;
} else {
//This is the worse case, we actually need a redirect
sec_rec->id = sec_rec->id | REDIRECTED_MASK;
sec_rec->target.redirect = pri_rec;
pri_rec->mem_count++;
}
}

Expand Down
Loading