fix: don't salvage wool thread into wool patches #4176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarf005
approved these changes
Jan 30, 2024
chaosvolt
deleted the
I-too-knit-using-just-knives-like-a-normal-human-being
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Don't allow cutting apart a pile of yarn into felt patches, doi.
Describe the solution
Added
NO_SALVAGEto yarn, just as thread has.Describe alternatives you've considered
Sinew and plant fiber don't seem to be made of materials that can be salvaged into anything, but keep in mind for if that ever changes.
Testing
Checked affected file for syntax and lint errors.
Additional context
Checklist