Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): Generic writ of trade #4196

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

Zlorthishen
Copy link
Contributor

@Zlorthishen Zlorthishen commented Feb 7, 2024

Purpose of change

changes NPC's Writ of trade from BOOK to GENERIC

Describe the solution

changes More NPC's Writ of trade item from type BOOK to type GENERIC

Describe alternatives you've considered

Testing

👍

Additional context

image

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Feb 7, 2024
@Zlorthishen Zlorthishen marked this pull request as ready for review February 7, 2024 02:44
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to remove the book-specific bits from the items, namely intelligence and time.

Setting stackable to true might also be good?

chaosvolt
chaosvolt previously approved these changes Feb 7, 2024
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I might have to later on follow up with an update to move this to currency files and see what it's missing to allow it to stack, oh well.

@chaosvolt chaosvolt merged commit 26d6ec0 into cataclysmbnteam:main Feb 7, 2024
9 checks passed
@Zlorthishen Zlorthishen deleted the generic-writ-of-trade branch March 10, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants