Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): further standardize and increase use of ranged bash info #4198

Conversation

chaosvolt
Copy link
Member

Purpose of change

This does a bit of standardizing and cleanup for ballistic resistance of furniture and terrain before I work on applying the feature to more stuff.

Describe the solution

  1. In general, all standard terrain and furniture with ranged bash data already specified now have their reduction properly set to an amount ranging from half their str_min (rounded up if needed) to str_min. Before I used arbitrary ranges that kinda sorta peaked at close to bash_min, but often I was using 5-10 values for basically anything with less than 15 bash_min, 10-20 for stuff in the 10-25 range, etc. This made very fragile terrain a bit tankier as ballistic protection than probably desirable, made a few substantially solid obstacles no better than some that could reasonably be considered more fragile, not to mention looked more arbitrary and weird.
  2. Fixed a few oddball destroy thresholds.
  3. Beefed up str_min of road barricades, centrifuges, CVD body, and bulletin boards a bit to justify more fitting ranged bash values.
  4. Likewise, beefed up str_max of brick chimneys to ensure the destroy thresh was still fittingly lower.
  5. Any case where an object's reduction or destroy_threshold does not match the current conventions for bash info now has a comment to bring it up and why it's like that.
  6. Applied ballistic resistance to a few more terrain obstacles and the like. Basically just finishing up applying these stats to furniture and terrain types that already had these partially implemented. Still haven't covered all doors and windows yet because jfc so many of them weh.
  7. Misc: fixed variant gas pump being magically indestructible.

Describe alternatives you've considered

Eternal screaming.

Testing

Ported JSON changes over to test build and load-tested.

Additional context

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Feb 7, 2024
Copy link
Contributor

autofix-ci bot commented Feb 7, 2024

The Autofix app has found code style violation and automatically formatted this Pull Request.

I locally edit my commits (e.g: git, github desktop)

Please choose following options:

I'd like to accept the automated commit
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

This PR is complete and I don't want to edit it anymore

It's safe to ignore this message.

I edit this PR through web UI

You can ignore this message and continue working.

I have no idea what this message is talking about

You can ignore this message and continue working. If you find any problem, please ask for help and ping @scarf005.

@scarf005 scarf005 merged commit 287326e into cataclysmbnteam:main Feb 10, 2024
9 checks passed
@chaosvolt chaosvolt deleted the ranged-bash-info-ballistic-standardizing branch February 10, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants