Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make grenades fire immune #4201

Merged
merged 5 commits into from
Feb 8, 2024
Merged

fix: make grenades fire immune #4201

merged 5 commits into from
Feb 8, 2024

Conversation

End3r991
Copy link
Contributor

@End3r991 End3r991 commented Feb 8, 2024

Purpose of change

This change make grenades fire immune, like in reality, they won't be destroyed by fire.

Describe the solution

Eliminate the plastic material from grenades completely, making them fire immune and simulating the structure of the M67 fragmentation grenades, which are completely made of steel.

Describe alternatives you've considered

Testing

With these changes, the grenades don't get destroyed immediatly in fire, wich is not what should happen in reality.

Additional context

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Feb 8, 2024
@chaosvolt
Copy link
Member

Just making them all-steel is probably better than hacking in a new material solely for 2 items.

Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eliminate the plastic material from grenades completely, making them fire immune and simulating the structure of the M67 fragmentation grenades, which are completely made of steel.

If so, it might be better to completely remove plastic usage over creating a new material as non-flamable plastic is only used for this single use-case.

@End3r991 End3r991 marked this pull request as draft February 8, 2024 06:59
@End3r991 End3r991 marked this pull request as ready for review February 8, 2024 07:00
@End3r991 End3r991 marked this pull request as draft February 8, 2024 07:00
@End3r991 End3r991 marked this pull request as ready for review February 8, 2024 07:08
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. thank you!

@chaosvolt chaosvolt merged commit 4b7cabe into cataclysmbnteam:main Feb 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants