Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): finish extending ranged bash info to windows, doors, and other half-implemented terrain; some window fixes #4219

Merged

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented Feb 11, 2024

Purpose of change

This finally applies ranged bash info to the remaining doors and windows that already had ranged data partially in use.

Describe the solution

  1. Belatedly added ranged data to triffid furniture that was added while the original implementation of furniture ranged bash info was being worked on.
  2. Finally gave all the variations on closed doors ranged bash info instead of only the basic ones having it, derp.
  3. Fixed one case of mistakening giving an open door ranged data.
  4. Gave ranged bashed info to all other transparent walls that lacked this, the rest will come next PR.
  5. Misc: gave half-built columns a coverage value.
  6. Updated windows with some missing ranged data.
  7. Important: I learned that for some reason bash info isn't fully overriden when specified. Windows seem to be deliberately using this to not have to copy strength and noise and such, but it had a side effect of allowing open windows to ALWAYS catch bullets as if they were closed windows. To fix that I found one can slap a new ranged bit on these that specify a 0% intercept chance.
  8. Minor: typofixes.
  9. Minor: fixed being able to walk into a closed window variant or two.

Side note: metal grate windows are WEIRD. They seem to be flavored like barred windows but they oxytorch/deconstruct into up-armored BOARDED UP windows, yet you can see through them as if they were just barred windows. But those windows can be easily smashed into a version that is then tougher but no longer has glass, while this smash into an empty window frame but take massive punishment. These were also where all the typo fixes came in, the descriptions all had a copypasted line that was malformed in the same way every time.

Describe alternatives you've considered

screm

Testing

  1. Checked affected files for syntax and lint errors.
  2. Load-tested in compiled test build.
  3. Tested that setting intercept chance of open windows to 0% fixes the issue of them being shot apart as if they were closed windows.

Additional context

Checklist

…nd other half-implemented terrain; some window fixes
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Feb 11, 2024
@chaosvolt chaosvolt changed the title feat(balance): finish extending ranged bash info to windows, doors, a… feat(balance): finish extending ranged bash info to windows, doors, and other half-implemented terrain; some window fixes Feb 11, 2024
@scarf005 scarf005 merged commit 9ff70a4 into cataclysmbnteam:main Feb 18, 2024
10 checks passed
@chaosvolt chaosvolt deleted the ranged-bash-info-finish-doors-windows branch February 18, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants