-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(port): cache NPC goal #4225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaosvolt
changed the title
Performance(port): Cache NPC goal
Feat(performance, port): Cache NPC goal
Feb 13, 2024
chaosvolt
changed the title
Feat(performance, port): Cache NPC goal
Feat(performance, port): cache NPC goal
Feb 13, 2024
End3r991
changed the title
Feat(performance, port): cache NPC goal
perf(port): cache NPC goal
Feb 13, 2024
chaosvolt
reviewed
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commits are missing co-authors despite being ported from DDA. could we attribute the original authors with this? |
Worth a try yeah. Last time I checked their branch out and amended last commit, and it instead created a new commit with the crediting added... |
Co-authored-by: David Seguin <davidseguin@live.ca>
Co-authored-by: David Seguin <davidseguin@live.ca>
scarf005
force-pushed
the
npc_perf_cache
branch
from
February 14, 2024 15:05
2e99700
to
c90932a
Compare
scarf005
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
One of the PR ported for #3073.
Describe the solution
Describe alternatives you've considered
Testing
Additional context
Source PR: Performance: Cache NPC goal, by @dseguin: CleverRaven/Cataclysm-DDA#54312
Checklist