fix: Changed 'Mature Plant' to 'Maturing Plant' #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thus, slightly less confusion
scarf005
approved these changes
Feb 15, 2024
chaosvolt
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
As pointed out by a member of the Discord, it's a little confusing how "Mature" plants aren't actually ready to harvest yet. Thus, this change is for clarity and to make it perfectly clear that it's not yet harvestable
Describe the solution
Changed "Mature" to "Maturing" in the JSON file containing the single furniture id that every plant secretly points to when in the mature stage (and also changed the one for plants in planters too of course)
Describe alternatives you've considered
Considering how this name change would affect every plant, not sensible. Would work decently well if we ever rework the plants system for some reason though.
Testing
Checked to make sure the game didn't yell at me, and that it indeed does what it should. Should be auto-linted since I moved to VSCode where I can use the plugin.
Additional context
Change suggested by Cürt in the Discord.
Left the ids themselves alone because changing them would be too much work and they still work perfectly fine given the simplicity of the change.
No clue what to mark this PR as other than chore, but that didn't really feel right so I went with next best thing of fix