fix: handle skinning batch jobs correctly #4269
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
This PR fixes the inability to batch skin or field dress multiple corpses at once. The relevant code that would check if the corpses have skin/organs only worked if a specific corpse index had been selected, i.e. if the corpse index was something other than -1.
This fixes the issue for both organs and skin as the checks are clustered together.
Fixes #4094
Describe the solution
Fix simply checks if any of the corpses have skin/organs in order to trigger the appropriate submenu selections in the butcher menu. The behavior remains effectively the same if the player is targeting a specific corpse, it only changes behavior for batch butchering.
Describe alternatives you've considered
Not fixing this in hopes of more players turning vegan.
Testing
Tested following scenarios:
Additional context
Butchering is messy business
Checklist