fix: crashing when viewing armor item with undefined resitances #4303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
fix #4302
Items that are categorized as armor but don't have defined resistances will crash the game upon view.
Describe the solution
This was previously crash safe because we were using a null check, but the behavior was wrong. Added the null check back.
Describe alternatives you've considered
letting chaos scream and cry
Testing
Loaded up game, scrolled through entire debug spawner for items, no crash. Item resistance values look fine.
Additional context
Not a fix for INT_MIN physical resistance on some smaller items; I can't reproduce that issue on windows.