Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refugee center back room monster group #4304

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

Zlorthishen
Copy link
Contributor

Purpose of change

currently, the monsters which spawn in in the refugee center are from the group GROUP_MALL. this is not normally a problem, until multiple mod interactions cause unintended and extra monsters to spawn for this quest.

Describe the solution

creates a new monster group, GROUP_REFUGEE_CENTER_BACK_ROOM which controls which monsters will spawn

Describe alternatives you've considered

Testing

👍

Additional context

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Mar 5, 2024
Copy link
Contributor

autofix-ci bot commented Mar 5, 2024

The Autofix app has found code style violation and automatically formatted this Pull Request.

I locally edit my commits (e.g: git, github desktop)

Please choose following options:

I'd like to accept the automated commit
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

This PR is complete and I don't want to edit it anymore

It's safe to ignore this message.

I edit this PR through web UI

You can ignore this message and continue working.

I have no idea what this message is talking about

You can ignore this message and continue working. If you find any problem, please ask for help and ping @scarf005.

@Zlorthishen Zlorthishen marked this pull request as ready for review March 5, 2024 22:34
@chaosvolt
Copy link
Member

chaosvolt commented Mar 5, 2024

No later-game necros and masters like GROUP_MALL has? Fair I suppose since a master can royally screw up the center if it evolves a lot of stuff, hmm.

@Zlorthishen
Copy link
Contributor Author

Fair I suppose since a master can royally screw up the center if it evolves a lot of stuff, hmm.

yeah, i had that happen before when i had a Next Summer scenario with accelerated monster evolution. half the npcs were dead before i even stole all the gas from the busses

Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cri but

@scarf005 scarf005 changed the title feat(content): Fix Refugee center back room fix: Refugee center back room monster group Mar 5, 2024
@chaosvolt chaosvolt merged commit da9a045 into cataclysmbnteam:main Mar 5, 2024
10 of 12 checks passed
@Zlorthishen Zlorthishen deleted the backroom_monstergroup branch March 6, 2024 00:25
@Zlorthishen Zlorthishen restored the backroom_monstergroup branch March 10, 2024 00:54
@Zlorthishen Zlorthishen deleted the backroom_monstergroup branch March 10, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants