fix: fixes cabin pool having salt water shallows #4316
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Found that the lil pool around one cabin variant had normal water for its deep water, but salt water for the shallows.
Describe the solution
Set the cabin palette to use regular water for shallow water, like it does for deep water.
Describe alternatives you've considered
Doing it the other way around because having a giant pool of salt water outside your house with a water slide is definitely logical. :3
Testing
q
andQ
from the palette actually show up, and that No Hope didn't do anything screwy with mapgen palettes for once.t_water_dp
is indeed the correct terrain ID.Additional context
Checklist