Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes cabin pool having salt water shallows #4316

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

chaosvolt
Copy link
Member

Purpose of change

Found that the lil pool around one cabin variant had normal water for its deep water, but salt water for the shallows.

Describe the solution

Set the cabin palette to use regular water for shallow water, like it does for deep water.

Describe alternatives you've considered

Doing it the other way around because having a giant pool of salt water outside your house with a water slide is definitely logical. :3

Testing

  1. Checked that this cabin variant was the only actual case where q and Q from the palette actually show up, and that No Hope didn't do anything screwy with mapgen palettes for once.
  2. Checked that t_water_dp is indeed the correct terrain ID.

Additional context

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Mar 8, 2024
@scarf005 scarf005 merged commit 5fdfd73 into cataclysmbnteam:main Mar 8, 2024
10 checks passed
@chaosvolt chaosvolt deleted the cabin-water-fix branch March 8, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants