feat(UI): move item notes to be with description, move MAGIC_FOCUS
flag description to flag section
#4339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
This implements a lil streamlining of some item UI stuff.
Describe the solution
C++ changes:
item::basic_info
that places a description for theMAGIC_FOCUS
flag directly above the item's description, as this is almost never actually important enough to be given such prominant placement.item::final_info
and intoitem::basic_info
immediately below the item's basic description. This places it where you'd expect flavor text of this sort to be instead of being way down in its own dedicated section, separated by horizontal rules.JSON changes:
MAGIC_FOCUS
flag its orignal hardcoded text as its flag description.Describe alternatives you've considered
Keeping item incriptions isolated by separators but still move them to directly below item description. I slapped some
<info>
on it so it doesn't blend in with the description though, so should be fine.Testing
Additional context
Checklist