Skip to content

fix: stop ghee from spoiling as fast as butter #5251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

RoyalFox2140
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 commented Aug 26, 2024

Checklist

Required

Purpose of change

When #4113 ported Nonperishable overhaul the spoil time for ghee was deleted, but it copies from butter. It was meant to not spoil in that PR, this overwrites it to not spoil.

Describe the solution

Spoils in is set to 0 days

Describe alternatives you've considered

None

Testing

Tests.

Additional context

Not a day goes by when I don't hate copy-from.

@github-actions github-actions bot added the data label Aug 26, 2024
@chaosvolt
Copy link
Member

chaosvolt commented Aug 26, 2024

Funny enough I'm fairly certain Nonperishable Overhaul didn't actually include an override for ghee, since it wasn't in the game back when I added it and it's almost always found in sealed jars anyway...

Definitely should last longer than regular butter either way, it probably could be okay with still being perishable but longer-lasting but on the other hand this gives the player an additional way to preserve milk, plus long-term perishable foods are still wonky anyway so this is fine too.

@RoyalFox2140 RoyalFox2140 merged commit 61530bb into cataclysmbnteam:main Aug 26, 2024
9 checks passed
@RoyalFox2140 RoyalFox2140 deleted the fix-ghee branch August 26, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants