Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: feat(balance): changes in base zombie drops #5633

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Conversation

RoyalFox2140
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 commented Oct 31, 2024

Checklist

Required

Purpose of change

#5197 slashed firearm spawn rates by 70%, changed tool spawns by a large amount, and cut back on the amount of smokers and thus available morale boosts via cigs a lot. These changes were snuck in relatively quietly as the community wasn't informed at such a huge shift in loot, additionally After I spoke with Chaosvolt he seemed unaware of how significant the firearm spawns were slashed.

Describe the solution

Revert. Something of this dramatic decision needs polling. I've talked to a number of people on the Discord, people notice there's a lot less guns but don't understand why, this was never communicated.

Describe alternatives you've considered

Partial revert, but we'll work on it more as a group.

Testing

It worked before this PR and it worked after. Tests will test.

Additional context

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Oct 31, 2024
@scarf005 scarf005 changed the title feat(balance): Revert Pull #5197 revert: feat(balance): changes in base zombie drops Oct 31, 2024
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things in the revert seem okay to keep, the rest seems acceptable to revert.

RoyalFox2140 and others added 3 commits October 31, 2024 11:55
Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
@RoyalFox2140
Copy link
Collaborator Author

@chaosvolt Check it now, suggestions comitted

@chaosvolt chaosvolt merged commit 312f037 into main Oct 31, 2024
9 checks passed
@RoyalFox2140 RoyalFox2140 deleted the revert-5197-distri branch October 31, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants