-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(balance): Convert drugdeal itemgroup to collection #5635
feat(balance): Convert drugdeal itemgroup to collection #5635
Conversation
Interesting, a lot of single-item spawns in the collection could still potentially be rolled up into itemgroup calls I suspect. We can roll the rest up in a follow-up PR if need be though, since the file changes are so jumbled now that it's not going to be convenient to add change suggestions to it. XD |
Wasn't sure generally how we wanted to handle it, I think it could use more work grouping some spawns but I didn't know where to go with it generally. |
Fair enough. I could mess with it if you'd like. Currently preparing draft updates for mods (and also waking up bleh). |
Went ahead and condensed the itemgroups a lot more, lemme know if it looks okay. |
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
Chaos's tweaks look good to me. Think this will be good overall |
To account for cataclysmbnteam#5635, moved to `guns_pistol_common`, as the items being injected are pistols.
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Purpose of change
When map extras were jsonized, the drugdeal map extra had all of its firearm spawns in a distribution that contained large amounts of clothing and other items like cigs, lighters, the drugs, etc. This meant it was nearly impossible for the game to roll for weapons.
Describe the solution
Update into a collection and heavily change what can spawn, being a collection means each item has a chance to roll instead.
Describe alternatives you've considered
Better distribution?
Testing
Additional context
@chaosvolt You must update Cataclysm++ as it sets drugdeals to a collection and that stops my game from loading. Basegame loads just fine, in fact most mods load fine.