Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): Buffed survivor armors, Plastic Armors #5651

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

yay855
Copy link
Contributor

@yay855 yay855 commented Nov 2, 2024

Made the few survivor armors I missed last time I did this have armor values close to the kevlar vests they use as ingredients. Also decreased football armor and hard plastic chestguards' encumbrance, they were encumbering as hell despite being half-decent earlygame armor.

Checklist

Required

Optional

Purpose of change

There were multiple survivor armor pieces that had much worse protection than the kevlar vest they used as a crafting ingredient, and football armor and hard chestguards were way too encumbering for how mediocre they are as armor.

Describe the solution

The survivor duster, survivor trenchcoat, scavenger armor, and corresponding gear pieces (boots, gloves, hoods, etc) have had their thickness increased in order to boost their armor values. Scavenger gear has had its recipe and description changed to be less dependent on pre-cataclysm equipment, since that's kind of an odd concept to begin with at such high tailoring levels.

The football armor and hard chestguard items have had their encumbrance lowered. They are early to midgame armor pieces, they do not need to have 20-35 encumbrance.

Describe alternatives you've considered

Testing

Additional context

Made the few survivor armors I missed last time I did this have armor values close to the kevlar vests they use as ingredients. Also decreased football armor and hard plastic chestguards' encumbrance, they were encumbering as hell despite being half-decent earlygame armor.
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 2, 2024
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should point out that you're removing submaterials from a lot of survivor items. I feel like this is a bad idea because it does two things in particular:

  1. Makes the items a lot more bland and same-y in terms of protection stats.
  2. Makes them more expensive to repair.

This was already done to the standard tiers of survivor suit for example, so this will make the affected items just a bit less distinct from them.

@yay855
Copy link
Contributor Author

yay855 commented Nov 3, 2024

I should point out that you're removing submaterials from a lot of survivor items. I feel like this is a bad idea because it does two things in particular:

1. Makes the items a lot more bland and same-y in terms of protection stats.

2. Makes them more expensive to repair.

This was already done to the standard tiers of survivor suit for example, so this will make the affected items just a bit less distinct from them.

Right, that's reasonable. I can increase the thickness instead, I suppose.

@RoyalFox2140
Copy link
Collaborator

Armor stats can be overwritten directly if that's more appropriate.

@chaosvolt
Copy link
Member

Either could work, ye

@Coolthulhu
Copy link
Member

How does it change the actual armor values?

@ZChris13
Copy link

ZChris13 commented Nov 4, 2024

the survivor duster niche exists entirely as a lightly encumbering armor that grants wet protection that won't get torn up by everything you see, in comparison to the rain coat and unfolded poncho
I don't think it needs to be super bulletproof

Restored prior materials to survivor gear, increased thickness to compensate. Added some additional ingredients for the scavenger cowl and scavenger gear to make them a bit less annoying to craft, and changed their materials from kevlar/cotton to kevlar/plastic to further differentiate it from the survivor gear.
@RoyalFox2140
Copy link
Collaborator

the survivor duster niche exists entirely as a lightly encumbering armor that grants wet protection that won't get torn up by everything you see, in comparison to the rain coat and unfolded poncho I don't think it needs to be super bulletproof

It should be as protective as the kevlar vest used to craft it at a bare minimum or you're in a situation where reality has broken down.

@chaosvolt
Copy link
Member

It should be as protective as the kevlar vest used to craft it at a bare minimum or you're in a situation where reality has broken down.

I mean, it depends. If you're spreading the kevlar vest out over a larger garment, then that means a lower layer count for any given area. Otherwise we'd have to set it so either only the torso gets max protection, or you have to use more than one, or use more than one vest to line all parts of the item with the same thickness of kevlar.

@ZChris13
Copy link

ZChris13 commented Nov 4, 2024

If the duster was supposed to be armor it wouldn't have only 85% coverage.

EDIT: maybe making it easier to craft would be better

@yay855
Copy link
Contributor Author

yay855 commented Nov 4, 2024

Maybe reflavoring the survivor duster into a lightly kevlar lined duster? That could work. Instead of taking a full kevlar vest, just take a few pieces of kevlar.

Reduced thickness of survivor duster and trenchcoat, also reduced amount of kevlar needed to craft it.
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will make light survivor body armor consistent with survivor cargo pants.

data/json/items/armor/torso_armor.json Outdated Show resolved Hide resolved
data/json/items/armor/torso_armor.json Outdated Show resolved Hide resolved
yay855 and others added 2 commits November 4, 2024 18:06
Co-authored-by: Chaosvolt <chaosvolt@users.noreply.github.com>
@chaosvolt
Copy link
Member

How does it change the actual armor values?

Survivor wetsuit:
image

Survivor firesuit:
image

Survivor duster:
image

Survivor cargo pants (light survivor body armor matches this value):
image

Light survivor cargo pants:
image

Scavenger cowl:
image

Scavenger gear:
image

Side note: I just realized light survivor body armor maybe could stay the same strength as light survivor cargo pants, but the fact we have two different strengths of survivor cargo pants is weird.

@chaosvolt
Copy link
Member

General thoughts:

  1. Scavenger gear and cowl have pretty damn high protection values. Then again, they don't really have any niche in between nomad gear and actual survivor gear anyway that comes to mind so them being beefed up doesn't really screw with balance.
  2. Survivor cargo pants and light survivor cargo pants are just...weird. It makes it more of a headache for me to figure out which one the light survivor body armor is supposed to be consistent with since that item doesn't have two separate tiers like the pants do.

Other than those stray thoughts the buffs are okay I guess. All the survivor clothing still stays below light survivor suits protection-wise which is where they should be. Scav gear beats it but again scavenger gear doesn't really fit in anywhere so doesn't matter.

@yay855
Copy link
Contributor Author

yay855 commented Nov 5, 2024

TBH we might be better off just obsoleting the light survivor cargo pants.

@chaosvolt chaosvolt merged commit bacf153 into cataclysmbnteam:main Nov 5, 2024
9 checks passed
@yay855 yay855 deleted the more-survivor-armor-buffs branch November 5, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants