Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): no monotony penalty for stimulants or depressants #5652

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

Soadreqm
Copy link
Contributor

@Soadreqm Soadreqm commented Nov 2, 2024

Checklist

Required

Optional

Purpose of change

The morale bonus from eating a specific food drops by two every time you eat it, and slowly returns over time, to represent the PC getting bored of a particular food. The exception to this is things with the junk_food material, meaning candy, chips, sugary soft drinks and that sort of thing. It also doesn't apply to things that aren't considered "food" - cigarettes, chewing gum and heroin never get boring.

I think alcohol and coffee should behave more like drugs in this regard. Right now, if you drink three cups of coffee, you lose your ability to enjoy coffee, and won't get it back unless you wait several days before taking more coffee. Given that many people drink several cups per day, I don't think it really gets boring like that.

Describe the solution

Made food items with nonzero stim value default to zero monotony_penalty. This currently includes:

  • all types of alcohol
  • all types coffee and tea
  • some types of herbal tea, including bee balm and chamomile but not literal "herbal tea"
  • alien fronds, leech flowers and leech bark
  • cacao nibs and cacao pods
  • coca leaves

It can be overridden on a per-item basis, though there are no items that do that right now.

Describe alternatives you've considered

It would also be possible to add a check for the "alcohol" material, and set monotony_penalty manually for coffee and tea, but I think checking for stim gets a pretty good list. Cacao nibs actually contain caffeine in game, though cacao pods don't. The alien plants are the weird one, but given how they're described, I think it's reasonable to assume that they're at least somewhat psychoactive and not just really tasty. If there are items there that should still get a monotony_penalty, there's fewer of them than there are types of coffee and tea.

Testing

Compiled and loaded game. Drank three cups of coffee, coffee still tasted good. Drank three shots of whiskey, still tasted good.
Since the monotony_penalty value wasn't used anywhere, temporarily gave sake a penalty of 10. Morale bonus decreased by 10 for each sip.

Additional context

@github-actions github-actions bot added the src changes related to source code. label Nov 2, 2024
@scarf005 scarf005 merged commit 973e2c6 into cataclysmbnteam:main Nov 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants