Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cap max duration of triffid pollen, string-ify time amounts for venom effects #5660

Merged

Conversation

chaosvolt
Copy link
Member

Checklist

Required

Optional

Purpose of change

Discussion in the BN server led me to notice that the triffid pollen effect introduced in #4154 has no max duration, which is generally something we prefer not to pair with an effect being able to inflict damage over time on the player.

Along the way I spotted a few other oddities.

Describe the solution

  1. Assigned a max duration of 1 hour to triffid pollen.
  2. Converted the two venom effects from integer durations to strings.

Describe alternatives you've considered

Screaming.

Testing

  1. Checked affected file for syntax and lint errors.
  2. Load-tested in compiled test build.
  3. Hotboxed myself in a cloud of alien plant jizz and confirmed the debug menu showed the duration wasn't exceeding the expected amount.

Additional context

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 3, 2024
@chaosvolt chaosvolt enabled auto-merge (squash) November 4, 2024 00:21
@chaosvolt chaosvolt merged commit 98df153 into cataclysmbnteam:main Nov 4, 2024
9 checks passed
@chaosvolt chaosvolt deleted the fix-pollen-and-also-int-durations branch November 4, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants