Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): Update Dodge modifier calculations, books train you more #5666

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

RoyalFox2140
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 commented Nov 4, 2024

Checklist

Required

Purpose of change

Base dodge is incredibly high without training, with training you become impossible to hit. We don't want to stop dodge builds from existing, but the earlygame math without mutations is too stacked from dex

Describe the solution

Every 2 points in dex would raise dodge modifier by 1. This sets it to every 4 points. This means at 8 dexterity you will have 2 modifier without training instead of 4, and at level 10 you wall have 12 modifier. At level 10 you ensure melee 7 enemies only can hit at a 16% chance. This is also before we calculate mutations or CBMs. At level 16 Dexterity it's back to 4 modifier and 14 at level 10.

In an effort to make it easier to train dodge the books now go to 2, 3, and 5. Dodge only trains on success, this is basically mandatory until someone sets it to train on failure.

Describe alternatives you've considered

N/A

Testing

I've done a fair bit of math on it, but you can too. Matching enemy melee skill is a 50% dodge chance. With the dodge 2 magazine you can gain 4 modifier and most enemies are between 3 and 5 earlygame.

The dodge tests will probably break. They have to be ran.

Additional context

Someone is going to be mad with me, but I think the dodge books is quality of life enough to make up for this.

@github-actions github-actions bot added src changes related to source code. JSON related to game datas in JSON format. labels Nov 4, 2024
@Coolthulhu
Copy link
Member

Looks like you also need to update the tests - balance tests assume dex/2 bonus and thus fail.

@RoyalFox2140
Copy link
Collaborator Author

Let me see those tests...

@github-actions github-actions bot added the tests changes related to tests label Nov 4, 2024
@RoyalFox2140 RoyalFox2140 merged commit 06b4f2c into cataclysmbnteam:main Nov 4, 2024
12 checks passed
@RoyalFox2140 RoyalFox2140 deleted the update-dodge-calc branch November 4, 2024 21:08
@scarf005
Copy link
Member

scarf005 commented Nov 4, 2024

could you please be explicit on whether it's a buff or nerf next time? "update" can mean both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. src changes related to source code. tests changes related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants