-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(content): Pockets, nomex padding #5671
feat(content): Pockets, nomex padding #5671
Conversation
Added nomex and pocketed padding, both are fairly minor additions that increase encumbrance by a little bit in exchange for a little more storage space and fire resistance.
Don't see that change on the file changes currently. |
What the- I must have removed it when removing the value changes to the armor padding. One moment and I'll re-add it. Edit: Done, it's back in now. |
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
Okay this is mildly bothering me. What PR set it so that it can be used to modify plastic and rigid kevlar? It would make sense for it to be able to repair all materials it can modify, but then that'd allow sewing up all-plastic and rigid kevlar items. This seems like a mistake was made at some point prior to this PR. I guess they don't HAVE to match, but... |
Yeah, I can remove the plastic and rigid kevlar modifications tomorrow if you like. |
Whichever works I guess, for now just injected scutes into the repair list as well since they're probably close enough to leather to allow being in both lists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how hard it'd be to code having it vary by item volume or the like...I might try to look into it, hmm. |
I think the best case would be if it was possible to just set a multiplier for each body part. Big pockets for torso and legs, little pockets for arms, tiny for hands, feet and head. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add for now and adjust in a follow-up PR I'm working on already.
Added nomex and pocketed padding, both are fairly minor additions that increase encumbrance by a little bit in exchange for a little more storage space and fire resistance.
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Optional
Purpose of change
Although some items ingame have pockets, you cannot sew pockets onto clothing, and you can't use nomex padding to make them more fire-resistant either. The number of fire-resistant clothes is actually quite few, and to be fair there are very few fire-spewing enemies.
Describe the solution
I have added two clothing mods, pocketed and nomex padded. Pocketed gives armor more pockets, nomex padded gives them fire resistance. I also added scute to the possible list of moddable clothing, since it is just bony, scaled leather.
Describe alternatives you've considered
Testing
Additional context