Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop wander spawns from spawning inside doorways #5682

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

RoyalFox2140
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 commented Nov 7, 2024

Checklist

Required

Purpose of change

Wander spawns cannot spawn on any terrain or furniture flagged as indoors. Doorways and open doors aren't indoors.

Describe the solution

This fixes the train wreck by forcing open doors to be indoors.

Describe alternatives you've considered

Escalating.

Testing

image

Additional context

image

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 7, 2024
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, worth noting door frames lack it too. May additionally be good to check and see if this needs to be applied to open windows and empty window frames as well.

@RoyalFox2140
Copy link
Collaborator Author

Looks good, worth noting door frames lack it too. May additionally be good to check and see if this needs to be applied to open windows and empty window frames as well.

That won't be as problematic but could be a followup.

@RoyalFox2140 RoyalFox2140 merged commit d309c46 into cataclysmbnteam:main Nov 7, 2024
9 checks passed
@RoyalFox2140 RoyalFox2140 deleted the doors-are-IN-doors branch November 7, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants