Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dandelion teas have vitamins #5752

Merged

Conversation

DoubleBullfrog
Copy link
Contributor

Dandelion tea as well as dandelion and burdock tea have the vitamins their respective ingredients have.

Checklist

Required

Purpose of change

Dandelion based teas should have vitamins as they're commonly drank for this reason IRL.

Describe the solution

Add the vitamins in their respective ingredients to the dandelion based teas.

Describe alternatives you've considered

Not doing this.
Doing spectroscopic analysis of dandelion tea to ensure exact accuracy of vitamin amounts. Unfortunately I do not own a near infrared spectrometer and they can cost up to $100k, so this would delay the PR significantly.

Testing

Made changes on my end and saw that dandelion teas have vitamins.

Dandelion tea as well as dandelion and burdock tea have the vitamins their respective ingredients have.
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 22, 2024
Copy link
Contributor

autofix-ci bot commented Nov 22, 2024

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@chaosvolt chaosvolt merged commit d867f10 into cataclysmbnteam:main Nov 22, 2024
9 checks passed
@DoubleBullfrog DoubleBullfrog deleted the dandelion-tea-has-vitamins branch November 29, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants