Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): ethanol and denatured alcohol have higher energy density than methanol #5756

Conversation

chaosvolt
Copy link
Member

Checklist

Required

Optional

Purpose of change

During discussion of #5750 it was noted that methanol should have a lower fuel value than ethanol or denatured alcohol, both since that's how it is IRL and for game balance reasons since methanol uses much simpler ingredients.

Describe the solution

Bumped the fuel value of ethanol (and by extension, denatured alcohol) from 15.6 to 24, with methanol now being explicitly set to use 15.6 as its fuel value.

In short, 15.6 MJ/L is the general value given for methanol as fuel IRL from most figures I could find, we bsically had it set so that all three alcohol types were using that value. The fuel values for ethanol I've seen range from 21.2 to Kheir saying they saw a value as high as 29, but 24 was the most common answer I could get.

Describe alternatives you've considered

For simplicity, denatured alcohol uses the same fuel value as ethanol for now. This is because the most common mixture is 10% methanol and 90% ethanol, and if I made denatured alcohol match that using the above numbers it'd come out to 23.16, which is a small enough difference compared to the value of ethanol that Coolthulhu advised it wasn't worth bothering with.

Testing

Checked affected file for syntax and lint errors.

Additional context

Checked DDA and all three alcohol types still use the same value as what methanol should have.

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 24, 2024
@RoyalFox2140 RoyalFox2140 merged commit ef66e60 into cataclysmbnteam:main Nov 24, 2024
9 checks passed
@chaosvolt chaosvolt deleted the booze-goes-vroom-when-not-made-from-trees branch November 24, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants