Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace full-body and balaclava cooling items with suit variant, clarify full-body effect in item description #5767

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented Nov 26, 2024

Checklist

Required

Optional

Purpose of change

So I belatedly didn't really as deep of a look at #5679 until recently and realized that the item variations are unnecessary, since having a single piece of clothing with the climate control flag will apply the effect to the whole body, not just the parts covered by that item. We can justify only bothering with the torso+arms+legs version providing a full-body effect via it affecting core body temperature, and obsolete the mask and full-body versions instead.

Describe the solution

  1. Moved the original full-body cooling outfit and the cooling balaclava to obsolete folder and obsoleted the recipes for them. Also added a JSON comment to the balaclava noting how it might be useful if we make climate control bodypart-specific in the future.
  2. Reworded the description for the cooling suit to better explain it affects the entire body.
  3. Misc: Fixed a redundant recipe for the thermal cooling outfit very obviously having meant to be a recipe for the thermal cooling suit that was previously overriding the "make a thermal cooling outfit from a thermal outfit" recipe variation.
  4. Replaced spawns of thermal cooling outfit in itemgroups with the suit variation.

Describe alternatives you've considered

Flailing at the code to make sources of climate control only affect the bodyparts they cover, which would then require I add thermal cooling gloves and socks to pair with the balaclava, in addition to making sure power armor helmets cool of the head separate from the rest of the armor.

Testing

  1. First actually tested before opening this PR to confirm that turning on a cooling balaclava would indeed correct temps for the entire body.
  2. Checked affected files for syntax and lint errors.
  3. Load-tested in compiled test build.

Additional context

… clarify full-body effect in item description
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 26, 2024
@chaosvolt chaosvolt enabled auto-merge (squash) November 26, 2024 17:34
@blot-runner
Copy link
Contributor

  1. Moved the original full-body cooling outfit and the cooling balaclava to obsolete folder and obsoleted the recipes for them. Also add

Last time I saw a line ending so abruptly, it was because somebody was posting about Candlejack and

@chaosvolt
Copy link
Member Author

Forgot to type the rest of that, snrk.

Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I hate it

@chaosvolt chaosvolt merged commit 5865454 into cataclysmbnteam:main Nov 26, 2024
9 checks passed
@chaosvolt chaosvolt deleted the cooling-outfit-goes-nyoom branch November 27, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants