Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): Buff supply drop items, rework their item spawning #5952

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

RobbieNeko
Copy link
Collaborator

Why should this PR be merged?

Supply drops are known for spawning very few items, and in general being very inconsistent on their value. This changes that by buffing their spawned items a good amount and getting rid of some of the silliness that they had with spawning their items. Should hopefully cut down on the disappointing crates.

What does this PR do?

  • Changes the number of crates spawned from 1-5 to 3-7
  • Rolls multiple times for itemgroups for the same crate
    • Places the itemgroup ids into a vector, then iterates over that vector when it comes time to spawn items
  • Rolls for 4 items instead of 2, and does it infinitely more sensibly
  • Makes sure that the return of the item-placing function isn't discarded and the variable to put a use for it isn't unused.

Steps to test and verify this PR

  • Compile test
  • Load into the game
  • Spawn a supply drop
  • Examine the crates
  • See the loot

Checklist

Mandatory

Additional notes

Compiled and tested on my machine, it works for me
image

I'm leaving the balancing of the itemgroups to someone else

3-7 crates suggested by Royal Fox

Co-Authored-By: Retagin <171521558+Retagin@users.noreply.github.com>
@github-actions github-actions bot added the src changes related to source code. label Jan 20, 2025
Copy link
Contributor

autofix-ci bot commented Jan 20, 2025

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@chaosvolt chaosvolt merged commit d20ac76 into cataclysmbnteam:main Jan 20, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants