Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: speed code change #6064

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

Goredell
Copy link
Contributor

@Goredell Goredell commented Feb 7, 2025

Checklist

Mandatory

Optional

  • This is a C++ PR that modifies JSON loading or behavior.
    • I have documented the changes in the appropriate location in the doc/ folder.
    • If documentation for this feature does not exist, please write it or at least note its lack in PR description.
    • New localizable fields need to be added to the lang/bn_extract_json_strings.sh script if it does not support them yet.
    • If applicable, add checks on game load that would validate the loaded data.
    • If it modifies format of save files, please add migration from the old format.

Purpose of change (The Why)

Describe the solution (The How)

TODO

Testing

When PR is out of draft it aims not to change basic behavior balance-wise. Which means game basically should work the same way.

Additional context

@github-actions github-actions bot added src changes related to source code. JSON related to game datas in JSON format. labels Feb 7, 2025
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactor musn't change original behavior. i think you meant feat?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants