Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trip pattern direction not saved properly #41

Closed
landonreed opened this issue Sep 20, 2017 · 0 comments
Closed

Trip pattern direction not saved properly #41

landonreed opened this issue Sep 20, 2017 · 0 comments

Comments

@landonreed
Copy link
Member

landonreed commented Sep 20, 2017 •
edited
Loading

When updating the trip pattern's direction using the UI, the direction value does not appear to be updating properly. The root cause appears to be that the TripPatternSerializer::serialize method is not being called properly for some reason (this happens in Base.java).

Nevertheless, it's not entirely clear that we even need this serializer. There is no issue in just delivering these values to the client as A and B as they are specified in the TripDirection enum (just needs a corresponding fix on the client).
landonreed added a commit to catalogueglobal/datatools-ui that referenced this issue Sep 20, 2017
@landonreed
fix(editor): update pattern direction values to reflect A/B values in…
fa0d543 
… Java enum

This corresponds to a change on datatools-server due to an issue with serializing these values to
the "standard" 0/1 values in GTFS.

refs catalogueglobal/datatools-server#41
This was referenced Sep 20, 2017
Merged
Merged
This was referenced Dec 7, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@landonreed