Create project and feed tweaks #255
Conversation
Codecov Report
@@ Coverage Diff @@
## create-project-and-feed #255 +/- ##
==========================================================
+ Coverage 4.95% 4.98% +0.02%
==========================================================
Files 328 328
Lines 15508 15419 -89
Branches 4693 4654 -39
==========================================================
Hits 768 768
+ Misses 12551 12488 -63
+ Partials 2189 2163 -26
Continue to review full report at Codecov.
|
| _handleKeyDown = (e: SyntheticKeyboardEvent<HTMLInputElement>) => { | ||
| switch( e.keyCode ) { | ||
| case 13: // ENTER | ||
| this._onSave() |
There was a problem hiding this comment.
There needs to be some kind of validation check done before calling _onSave. It's possible to create a feed source without a name with this change.
| _handleKeyDown = (e: SyntheticKeyboardEvent<HTMLInputElement>) => { | ||
| switch( e.keyCode ) { | ||
| case 13: // ENTER | ||
| this._onSaveSettings() |
There was a problem hiding this comment.
There needs to be some kind of validation check done before calling _onSaveSettings. It's possible to create a project without a name with this change.
|
OK, @evansiroky, I made some changes that address the onSave issue. Let me know how it looks. |
A few tweaks for #41:
validatorlibrary to validate URL (which is already used in editor)ENTER(to trigger save)